[Bug #1] Parameters are now passed successfully

[MisinformedDNA]

Code and tests added.

[MisinformedDNA]

I'm still new to Git, can you explain exactly where I'm supposed to do that?

[MisinformedDNA]

Also, I read this can be done in either .gitattributes or globally. Since you don't have a .gitattributes, I assume you want me to make a global config change? Will this affect other repos I'm working with?

[benfoster]

Generally it's good practice to set this globally to avoid this issue.

For more details see http://www.hanselman.com/blog/YoureJustAnotherCarriageReturnLineFeedInTheWall.aspx

On 17 May 2013, at 15:06, MisinformedDNA notifications@github.com wrote:

Also, I read this can be done in either .gitattributes or globally. Since you don't have a .gitattributes, I assume you want me to make a global config change? Will this affect other repos I'm working with?

— Reply to this email directly or view it on GitHub.

[MisinformedDNA]

Yea, I had read that article, I understand why there's a problem, but this is his proposed solution is:

You can setup a .gitattributes per repo to do things like this:

*.txt -crlf

Or you can do what GitHub for Windows suggests with text=auto.

Auto detect text files and perform LF normalization text=auto

Of course, it doesn't say exactly what I'm actually supposed to do... that or I keep missing it.

This however, seems like it could be useful: https://help.github.com/articles/dealing-with-line-endings as it tells me I need to run git config --global core.autocrlf true and then recommit files.

[benfoster]

Yes that command is correct.

On 17 May 2013, at 15:17, MisinformedDNA notifications@github.com wrote:

Yea, I had read that article, I understand why there's a problem, but this is his proposed solution is:

You can setup a .gitattributes per repo to do things like this:

*.txt -crlf

Or you can do what GitHub for Windows suggests with text=auto.

Auto detect text files and perform LF normalization text=auto

Of course, it doesn't say exactly what I'm actually supposed to do... that or I keep missing it.

This however, seems like it could be useful: https://help.github.com/articles/dealing-with-line-endings as it tells me I need to run git config --global core.autocrlf true and then recommit files.

— Reply to this email directly or view it on GitHub.

[MisinformedDNA]

I executed the commands per the instructions from GitHub and Git isn't picking up that there are any changes. I tried it again just to be sure and still nothing. Ideas?

[benfoster]

I think you'd probably need to roll back and then recommit your changes. I wouldn't worry too much - it's only a small change so I can always make it myself.

On 17 May 2013, at 15:17, MisinformedDNA notifications@github.com wrote:

Yea, I had read that article, I understand why there's a problem, but this is his proposed solution is:

You can setup a .gitattributes per repo to do things like this:

*.txt -crlf

Or you can do what GitHub for Windows suggests with text=auto.

Auto detect text files and perform LF normalization text=auto

Of course, it doesn't say exactly what I'm actually supposed to do... that or I keep missing it.

This however, seems like it could be useful: https://help.github.com/articles/dealing-with-line-endings as it tells me I need to run git config --global core.autocrlf true and then recommit files.

— Reply to this email directly or view it on GitHub.

[benfoster]

Have accepted your other pull request.