benfrain / rwd

Code samples from the book 'Responsive web design with HTML5 and CSS3'
152 stars 101 forks source link

Navigation menu #2

Open thomas-haslwanter opened 2 years ago

thomas-haslwanter commented 2 years ago

Hi Ben, since I don't know where else to post it, I send the comment here: In the 3rd ed of your book RWD, code example 04-02 does not work well in real life. By simply adding some content, the alignment of the elements gets quite messed up. Try for example, with the the following index.html ` <!doctype html>

Layout example

Header

Left

abc

def

  • one
  • two
  • three

Right

abc

def

` one gets the attached result.

rwd_0402
benfrain commented 2 years ago

Hi @thomas-haslwanter

The example was really only meant to give an illustration of the off-canvas pattern. However, if you want to stop the issue you are seeing, the simplest solution from that point would be adding vertical-align: top to the .Left and .Right selectors.

If you have read through the Chapter on Grid, you'll likely have a few other ideas of how you might approach this layout.

The chapter code and repo for the third edition is actually at: https://github.com/PacktPublishing/Responsive-Web-Design-with-HTML5-and-CSS-Third-Edition/issues (which should be linked up from the 3rd Edition website: https://rwd.education

Best, Ben

thomas-haslwanter commented 2 years ago

Hello Ben,

first of all: thank you for your incredibly fast response!! This was not expected.

Regarding your answer: I did read the Chapter on Grid – but did not find an idea for the dynamic loading of the menu ☹

Regards, Thomas

From: Ben Frain @.> Sent: Sunday, August 7, 2022 7:40 PM To: benfrain/rwd @.> Cc: Haslwanter Thomas @.>; Mention @.> Subject: Re: [benfrain/rwd] Navigation menu (Issue #2)

Sie erhalten nicht oft eine E-Mail von @.**@.>. Erfahren Sie, warum dies wichtig isthttps://aka.ms/LearnAboutSenderIdentification

Hi @thomas-haslwanterhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fthomas-haslwanter&data=05%7C01%7CThomas.Haslwanter%40fh-linz.at%7Cd58c3c53431e48ae463808da789bdf9b%7Cf88d4b736bb24b9aabc7eb96e5a6407c%7C1%7C0%7C637954908121123989%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VlTYMqaANbg2wg2txquGxdzK0I2K6A7ChoHq2VRRRJU%3D&reserved=0

The example was really only meant to give an illustration of the off-canvas pattern. However, if you want to stop the issue you are seeing, the simplest solution from that point would be adding vertical-align: top to the .Left and .Right selectors.

If you have read through the Chapter on Grid, you'll likely have a few other ideas of how you might approach this layout.

Best, Ben

— Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbenfrain%2Frwd%2Fissues%2F2%23issuecomment-1207453549&data=05%7C01%7CThomas.Haslwanter%40fh-linz.at%7Cd58c3c53431e48ae463808da789bdf9b%7Cf88d4b736bb24b9aabc7eb96e5a6407c%7C1%7C0%7C637954908121123989%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=8Lgn0zqbHyxmT2Lhhve6tjZeU38x%2Br8yYgbS8ufcq3Y%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAALVURLAE4TN5OCVI4Q4X6DVX7YG7ANCNFSM552PLMMQ&data=05%7C01%7CThomas.Haslwanter%40fh-linz.at%7Cd58c3c53431e48ae463808da789bdf9b%7Cf88d4b736bb24b9aabc7eb96e5a6407c%7C1%7C0%7C637954908121123989%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BFyrzstWxJ3yE5fEDLEcPyX9b4Goh%2FAsU9hIQvugwng%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>