Fix save/load for models that haven't been fit

benfred / implicit

Fast Python Collaborative Filtering for Implicit Feedback Datasets

https://benfred.github.io/implicit/

MIT License

3.57k stars 612 forks source link

Fix save/load for models that haven't been fit #577

Closed benfred closed 2 years ago

benfred commented 2 years ago

We were seeing errors calling the .save and .load methods on models that hadn't been fit yet. The problem was that the factors were None values - and couldn't be loaded back in without using pickle (which we disable). Fix and add a unittest