Tweak callback API - Githubissues

benfred / implicit

Fast Python Collaborative Filtering for Implicit Feedback Datasets

https://benfred.github.io/implicit/

MIT License

3.57k stars 612 forks source link

Closed benfred closed 2 years ago

benfred commented 2 years ago

Rename the 'fitcallback' parameter on the '.fit' method to just 'callback' (since the fit is redundant)
Update fit method signatures of subclasses like the ANN models and ItemItem models to be consistent with the base class
fix issue in implicit/cpu/als.py where the callback parameter wasn't being used, and add a unittest that tests this