search

benfred / implicit

Fast Python Collaborative Filtering for Implicit Feedback Datasets
https://benfred.github.io/implicit/
MIT License
3.57k stars 612 forks source link

Drop `setup_requires` #671

Closed jakirkham closed 1 year ago

jakirkham commented 1 year ago

Currently setup.py makes use of setup_requires

https://github.com/benfred/implicit/blob/2268ac78d08e4ab94ce53bd48b08bcd012878559/setup.py#L59

This is used to configure the cmake dependency (when building wheels IIUC)

https://github.com/benfred/implicit/blob/2268ac78d08e4ab94ce53bd48b08bcd012878559/setup.py#L10-L16

Though it appears this dependency can just be cmake>=3.17 and could be added to build-system.requires

https://github.com/benfred/implicit/blob/2268ac78d08e4ab94ce53bd48b08bcd012878559/pyproject.toml#L5-L12

Given all the issues with setup_requires, maybe it could just be dropped?

benfred commented 1 year ago

@jakirkham - I've dropped the setup_requires in #674

jakirkham commented 1 year ago

Thanks Ben! 🙏

If it is desirable to list the cmake dependency, could add it to pyproject.toml here:

https://github.com/benfred/implicit/blob/a19df795e89ac0171fbd756be520b3906017d8db/pyproject.toml#L5-L12

benfred commented 1 year ago

thanks @jakirkham - done in https://github.com/benfred/implicit/pull/677