benfred / implicit

Fast Python Collaborative Filtering for Implicit Feedback Datasets
https://benfred.github.io/implicit/
MIT License
3.57k stars 612 forks source link

Add `noexcept` declarations for Cython 3.0 #680

Closed benfred closed 1 year ago

benfred commented 1 year ago

This fixes a large performance regression with many of the CPU models.

For instance when training the ml100k dataset, when compiled with Cython 3.0.0:

Fixes #678