benfred / implicit

Fast Python Collaborative Filtering for Implicit Feedback Datasets
https://benfred.github.io/implicit/
MIT License
3.57k stars 612 forks source link

Add check_csr for partial_fit methods #683

Closed benfred closed 1 year ago

benfred commented 1 year ago

We were seeing some poor result on partialfit*, that ended up caused by passing a CSC instead of a CSR matrix. (#682)

Add the same check_csr code to the partial_fit methods that is already done in the fit method - this will warn if passed a non-csr matrix, and automatically convert.