benfred / venn.js

Area proportional Venn and Euler diagrams in JavaScript
MIT License
1.04k stars 218 forks source link

Handle 0 Size Gracefully #101

Closed theavijitsarkar closed 6 years ago

theavijitsarkar commented 7 years ago

Can there be a better representation if all elements are 0. Somehow the library breaks with errors if you try to send 0 size.

screen shot 2017-08-09 at 5 55 09 pm

screen shot 2017-08-09 at 5 54 03 pm

benfred commented 7 years ago

The last commit should fix - thanks for pointing this out!

theavijitsarkar commented 7 years ago

Same output still. Broken image at top left corner.

Shows error : not scaling solution: zero size detected

theavijitsarkar commented 7 years ago

error messages are gone, but is there a better representation possible?

theavijitsarkar commented 7 years ago

maybe like just the labels in the center without the circles

benfred commented 6 years ago

That last commit should fix (0 sized sets won't be displayed at all)

wykhuh commented 6 years ago

@benfred Zero values is causing errors again. I looked at the codebase, and the fix you added in February isn't in the current version of venn.js

Awesome library by the way.