Label don't update on dynamic venn.

benfred / venn.js

Area proportional Venn and Euler diagrams in JavaScript

MIT License

1.04k stars 218 forks source link

Label don't update on dynamic venn. #103

Closed djpate closed 7 years ago

djpate commented 7 years ago

I've been playing with dynamic venn following the example.

I've noticed two things.

If you have a single circle then you can't dynamicly change it size.
If you are using labels, they don't change if you want the data set.

Right now I got around it by removing the div and recreating it everytime but I would love to keep the animations if possible.

Any tips?

benfred commented 7 years ago

I fixed the labels not updating. The problem seems to be that when doing a data join in D3 - it returns the previous object rather than than the new object (meaning that the label attribute still had the old value). I fixed in the last commit by setting explicitly to the new version.

For your other issue - the diagram automatically scales itself to fit in the specified width/height. With a single circle, this means it will fill the whole div.