benfred / venn.js

Area proportional Venn and Euler diagrams in JavaScript
MIT License
1.04k stars 216 forks source link

Made it possible to specify the loss function. #114

Closed danielyule closed 6 years ago

danielyule commented 6 years ago

As described in #81, sometimes an overlap area will not be rendered on the screen. This can be fixed by updating the initial layout and the loss function (to prioritize ensuring all overlaps are shown). However, this may not be needed in every case, so a change to the default code is not needed. The initial layout can be replaced, but not the loss function. This PR adds the ability to specify the loss function externally.

benfred commented 6 years ago

thanks for the PR!