benfried / xld

Automatically exported from code.google.com/p/xld
0 stars 0 forks source link

Pre-Emphasis Not Detected Correctly on All CDs #247

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. Open Audio CD
2. Save Cue Sheet

How about the reproducibility (always, sometimes, rarely, ...)?

Always

What is the expected output? What do you see instead?

I expect to see FLAG PRE in the cue sheet, but no FLAG PRE is noted.

What version of the product are you using? On what operating system?

20131102 (145.0). Mac OS 10.9.2

Please provide any additional information below.

I have some CDs such as la Tremaenda 2004 CD and Pink Floyd's The Wall Japan 
for US 1984 CD that XLD does not detect pre-emphasis. For older CDs this is not 
a big issue, since everyone knows there is pre-emphasis on these CDs so you can 
just add the FLAG to the cue sheet manually. For more modern CDs it is hard to 
tell if the CD has pre-emphasis or if it just sounds/recorded bad. It would be 
good if XLD could reliably detect pre-emphasis.

Original issue reported on code.google.com by richardh...@gmail.com on 8 Apr 2014 at 8:31

GoogleCodeExporter commented 9 years ago
OK, I have been doing a bit more research, and it seems that the CDs I have 
where pre-emphasis is NOT detected by XLD contains the pre-emphasis flag in the 
subchannel only.

I am guessing that XLD checks the TOC for pre-emphais but not the subchannel 
data?

It would be great if XLD could check the subchannel data for pre-emphasis as 
well since I don't think there is any program on Mac OS that will report 
pre-emphasis from the subchannels (I have tried iTunes, Roxio Toast, Terminal, 
etc). I know both CueRipper and EAC will check subchannel information on 
Windows, but it would be nice to have this option on Mac as well.

Original comment by richardh...@gmail.com on 8 Apr 2014 at 6:37

GoogleCodeExporter commented 9 years ago
How about this? http://tmkk.pv.land.to/xld/XLD_dev_140409.zip

Original comment by tmkkmac on 9 Apr 2014 at 2:55

GoogleCodeExporter commented 9 years ago

Cheers mate for such a fast response!

I tried downloading the link a couple of times but keep getting the message 
"503 Service Temporarily Unavailable". I will try again tomorrow morning.

Original comment by richardh...@gmail.com on 9 Apr 2014 at 9:19

GoogleCodeExporter commented 9 years ago
Hmm, I can download the file without problem.

Original comment by tmkkmac on 9 Apr 2014 at 9:29

GoogleCodeExporter commented 9 years ago
Oops, my mistake; try this: http://tmkk.undo.jp/xld/XLD_dev_140409.zip

Original comment by tmkkmac on 9 Apr 2014 at 9:30

GoogleCodeExporter commented 9 years ago
Brilliant! That revision solves the problem for me.

The only oddity I have noted is that the cue sheet now also contains FLAGS DCP.
Although I am not 100% confident, I don't think this CD has copy protection.
In version 20131102 no FLAGS are detected at all for this CD.

Original comment by richardh...@gmail.com on 9 Apr 2014 at 5:36

GoogleCodeExporter commented 9 years ago
DCP flag is also recorded in the subchannel and this version detects the flag 
from subchannel.

Original comment by tmkkmac on 10 Apr 2014 at 2:25

GoogleCodeExporter commented 9 years ago
Fair enough. Thank so you much for your fast response to this issue!
I take it, this will be incorporated into the next update?

Original comment by richardh...@gmail.com on 10 Apr 2014 at 6:50

GoogleCodeExporter commented 9 years ago
Yes.

Original comment by tmkkmac on 10 Apr 2014 at 7:46

GoogleCodeExporter commented 9 years ago
This is a great feature update and I am very happy to see that XLD will soon 
check subchannel data for pre-emphasis information.

I just wanted to report, however, that I also note some odd behavior regarding 
DCP Flags in this version.

I have downloaded XLD_dev_140409 posted here and tested with 3 CDs made in the 
early 1980s (I think this should be before the introduction of audio CD copy 
protection). 1 CD has pre-emphasis in the TOC. 1 CD has pre-emphasis in the 
subchannel only. 1 CD has no pre-emphasis. Version XLD_dev_140409 correctly 
reports pre-emphasis on all CDs. It does, however, also report DCP on all 3 
CDs. 

Original comment by lalla.ch...@gmail.com on 22 Apr 2014 at 11:18

GoogleCodeExporter commented 9 years ago
See comment #7

Original comment by tmkkmac on 23 Apr 2014 at 1:13

GoogleCodeExporter commented 9 years ago
Woops, my mistake. I read this thread really late last night and got confused.
Flags DCP = Digital Copy Permitted.
I do notice that every CD I have tried with version XLD_dev_140409 reports 
FLAGS DCP.
Is this as expected? I guess I am just not used to seeing this flag in many cue 
sheets.

Original comment by lalla.ch...@gmail.com on 24 Apr 2014 at 2:04

GoogleCodeExporter commented 9 years ago
Fixed in version 20140427

Original comment by tmkkmac on 4 May 2014 at 3:16