benfry / processing4

Processing 4.x releases for Java 17
https://processing.org
Other
1.35k stars 239 forks source link

Syntax error highlighting placement / width incorrect. #714

Closed sampottinger closed 1 year ago

sampottinger commented 1 year ago

Description

Trying back to 4.1, error highlighting doesn't appear to be working (at least on Linux).

Expected Behavior

Expected a red underline at line 4 or 5.

Current Behavior

No line shown

Steps to Reproduce

Use the code provided and wait for error checking:

void setup() {
  size(100, 100)
  background(#FFFFFF);
}

void draw() {
}

Your Environment

Possible Causes / Solutions

I'll check if this is linux specific... possible there's something in theming or attribution.

sampottinger commented 1 year ago

Here it is on Linux...

v42

sampottinger commented 1 year ago

Looks like this is happening on my mac too...

sampottinger commented 1 year ago

However, it does work as expected on the 4.0.x releases it appears...

sampottinger commented 1 year ago

I'll try to see what happened here and get back soon. It looks like it might be a thing about placement / width but the errors are still correctly placed when running a full compile.

sampottinger commented 1 year ago

It looks like this came about potentially in conjunction with the language server implementation where the offset isn't being passed into the issue.

sampottinger commented 1 year ago

Looks like this came up in https://github.com/processing/processing4/commit/ac062a502dec646dd2f332ea12c32efc01064b1c when editor was not longer present for building Problems

sampottinger commented 1 year ago

I know we don't have an imminent release but this is is getting in the way of a GSoC project. To make sure he can still finish on time / pass, I'm going to merge this to main but I won't make a release. Without this sorted, the error message rewriting isn't visible to the user.