benfry / processing4

Processing 4.x releases for Java 17
https://processing.org
Other
1.35k stars 237 forks source link

Full line edt #772

Closed sampottinger closed 1 year ago

sampottinger commented 1 year ago

We got pretty close on #752. However, the EDT often will place errors in unexpected places and with a width of 1 character (gives us a point where there was a problem but not the correct number of characters involved). This does not impact ANTLR issues.

I believe that, previous to the efforts to improve error highlighting, earlier versions of Processing 4 were highlighting the whole line but stuff related to #752 and #715 tried to make this more precise. This PR restores that earlier behavior and formalizes the interface. See attached.

Note that this does not impact upsteram errors in the build pipeline, only things that get through to the EDT. It also does not change behavior for errors reported at compile or runtime using javac directly.

before after after_vscode

benfry commented 1 year ago

Looks good; thanks!