search

benfulcher / hctsa

Highly comparative time-series analysis
https://time-series-features.gitbook.io/hctsa-manual/
Other
734 stars 315 forks source link

compile_mex error from range_search.cpp file #67

Open faimai00 opened 2 years ago

faimai00 commented 2 years ago

Hi Ben,

I have encountered an error when compiling MEX as part of the installation process. When compiling the OpenTSTOOL, I get a series of warnings followed by an error. This is generated from the range_search.cpp file line 116 (see screenshot below):

Screenshot 2022-09-19 at 10 52 11

I suspect that the error arises as the code is trying to compare a range to an integer, which is an invalid operation? When justifying that part of the code, the MEX is compiled successfully (see screenshot below):

Screenshot 2022-09-19 at 10 52 53

I just wanted to share this and I would be grateful for any suggestions. FYI - I am using macOS Catalina v10.15.7 and Matlab R2021a.

Many thanks! Irene

benfulcher commented 2 years ago

Thanks for the detailed message, Irene! You are probably right about this—I'd be happy to receive a PR for an appropriate fix (e.g., a list of operations affected by this error).

The reason I'm reluctant to put energy into debugging TSTOOL in general is that it (as an external library) was never very well implemented (imo), and active development on it stopped >~ a decade ago. It would be better to remove reliance on TSTOOL altogether and transfer any that do depend on TSTOOL to modern, efficient, and actively developed alternative implementations of the same methods. A fix that could be considered is to remove all TSTOOL-related features (or at least the subset that are buggy)…