[Android Bootcamp] Submitting project prework (Todo App)

bengbeng2121 commented 8 years ago

Hi CoderSchool, this is my Todo App with a basic functionality for Android Bootcamp prework. Thank you. /cc @coderschoolreview

PS: I will improve my app next submitting

coderschoolreview commented 8 years ago

Thank you for your Android submission, binhle12!

:clap: Everything looks good with the format of your submission. We'll be reviewing your submission soon!

hoanle commented 8 years ago

Hi @binhle12

Thanks for submission

In general,

The app runs without any critical issue (such as crash)
Required features are done

Detail & Suggestion:

On edit mode, you forgot to check empty title
You can try to use DialogFragment, SQLite to store database or write your own adapter
Some widget can be configured shorter in XML file. Not all options are required For example

<EditText
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:id="@+id/etContent"
        android:layout_below="@+id/tvGuide"
        android:layout_alignParentLeft="true"
        android:layout_alignParentStart="true"
        android:layout_alignParentRight="true"
        android:layout_alignParentEnd="true" />

It has a lot of align option, but actually it does not need all of that to be what you want it to be.

bengbeng2121 commented 8 years ago

Hi @hoanle, thank you for your suggestion. I will fix it :) I'm updating my app using SQLite and CursorAdapter. And then UI. Ps: G9

bengbeng2121 / learning-android-2

[Android Bootcamp] Submitting project prework (Todo App) #1

Thank you for your Android submission, binhle12!