search

bengeisler / TcLog

Flexible logging functionality for TwinCAT 3.
MIT License
54 stars 10 forks source link

Nuisance warning about signed conversion in TcLogCore declaration #27

Open ben-ab-thompson opened 2 months ago

ben-ab-thompson commented 2 months ago

When declaring the instance of the core logger following the instructions,

TcLogCore(BufferSize := 100 (Tc2_System.MAX_STRING_LENGTH Constants.FifoOverhead));

The Twincat compiler throws a C0196 warning about the implicit sign conversion from untyped to typed. Inside the FB_Init method, this value is immediately recast from a DINT to a UDINT anyway Can the FB_Init method accept a UDINT for the BufferSize variable? This would align the internal method and prevent the warning.

bengeisler commented 2 months ago

Hi! Thanks for reaching out. This makes totally sense and should be easily fixable. I'll look into it.

ben-ab-thompson commented 2 months ago

Oh wow, talk about a fast response time! I tried doing it on my own, but I think I have a environment mismatch because it failed a test that didn't make much sense.

Thank you!

On Mon, Sep 23, 2024, 3:59 p.m. Benedikt Geisler @.***> wrote:

Hi! Thanks for reaching out. This makes totally sense and should be easily fixable. I'll look into it.

— Reply to this email directly, view it on GitHub https://github.com/bengeisler/TcLog/issues/27#issuecomment-2369119773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPWCVNYLD2PFOVSIZE24X3ZYBQIDAVCNFSM6AAAAABOWWI4ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRZGEYTSNZXGM . You are receiving this because you authored the thread.Message ID: @.***>