Execute node-gyp on install

bengfarrell / nuimotion

Node.js wrapper for OpenNI/NiTE offering skeletal joint tracking and gestures

http://www.sweatintotheweb.com/nuimotion-for-node-js/

MIT License

74 stars 19 forks source link

Execute node-gyp on install #3

Closed euforic closed 11 years ago

euforic commented 11 years ago

Added preinstall npm hook to execute node-gyp configure build on install

bengfarrell commented 11 years ago

I like the preinstall hook - I'm tempted to merge it, however on Windows I've found that there are build dependencies on the actual OpenNI/NiTE install package being there prior to building.

This is why I didn't include it. Any thoughts? Should I just go for it? What little I've seen of usage so far are Linux folks, so perhaps I could target linux and make note of the issue for Windows users

euforic commented 11 years ago

@bengfarrell I think it would be best to target linux and mac. Then work on any windows issues as they come. I know I will be more apt to contribute if I don't have to target windows as much :-)

bengfarrell commented 11 years ago

Perfect, I prefer doing this on Linux myself, but I do boot to Windows occasionally. Thanks for the opinion