search

benglassman / evidence-elections

0 stars 0 forks source link

Race to json #9

Closed benglassman closed 6 years ago

benglassman commented 6 years ago

removed all content logic from index.scala.html and moved to react components. Changed the application controller method to return JSON

ZachGlassman commented 6 years ago

Major points are that we should have a better default way of dealing with default state in a react component and also I'd like to use an orm perhaps oije the slick library. This will be better down the road to help mitigate SQL injection issues

benglassman commented 6 years ago

I have no clue about how to do react. Could you come up with guidelines for the inititial state of react html pending asynch return of data?

I can handle the orm implementation. Slick is the obvious choice, but I liked working through the direct sql to get my hands around what was happening.

Sent from my iPhone

On Aug 11, 2018, at 1:00 PM, ZachGlassman notifications@github.com wrote:

Major points are that we should have a better default way of dealing with default state in a react component and also I'd like to use an orm perhaps oije the slick library. This will be better down the road to help mitigate SQL injection issues

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

benglassman commented 6 years ago

merging for now since it's functional and an upgrade, new issues created for orm and better initial html state