search

bengott / meteor-avatar

Consolidated Avatar Template Package for Meteor
73 stars 21 forks source link

Rendering issues (Slava's screencast) #47

Closed SachaG closed 8 years ago

SachaG commented 9 years ago

I've noticed this slow-down issue ever since using the avatar package in Telescope. Would be awesome to fix it!

https://www.youtube.com/watch?v=AkSoLAFXrvE

/cc @slava

Slava commented 9 years ago

After digging around, I think the whole Telescope codebase relies on Meteor.user() everywhere?

bengott commented 9 years ago

Thanks Sacha and Slava. Good teaching lesson for using field specifiers, eh? And Telescope could probably use an overhaul too?

SachaG commented 9 years ago

Yeah definitely. This is something I completely overlooked. Probably worth writing a blog post about it…

On Sat, Feb 28, 2015 at 2:37 AM, Ben Gott notifications@github.com wrote:

Thanks Sacha and Slava. Good teaching lesson for using field specifiers https://docs.meteor.com/#/full/fieldspecifiers, eh? And Telescope could probably use an overhaul too?

— Reply to this email directly or view it on GitHub https://github.com/bengott/meteor-avatar/issues/47#issuecomment-76502839 .

Slava commented 9 years ago

I mean, it is probably not a big deal. You never see someone constantly updating the profile over and over again every 200ms.

On Fri, Feb 27, 2015 at 11:25 PM, Sacha Greif notifications@github.com wrote:

Yeah definitely. This is something I completely overlooked. Probably worth writing a blog post about it…

On Sat, Feb 28, 2015 at 2:37 AM, Ben Gott notifications@github.com wrote:

Thanks Sacha and Slava. Good teaching lesson for using field specifiers https://docs.meteor.com/#/full/fieldspecifiers, eh? And Telescope could probably use an overhaul too?

— Reply to this email directly or view it on GitHub < https://github.com/bengott/meteor-avatar/issues/47#issuecomment-76502839>

.

— Reply to this email directly or view it on GitHub https://github.com/bengott/meteor-avatar/issues/47#issuecomment-76515219 .

SachaG commented 9 years ago

But I've certainly seen UI slowdowns since around the time we implemented avatars. So it might be related.

On Sat, Feb 28, 2015 at 9:11 AM, Slava Kim notifications@github.com wrote:

I mean, it is probably not a big deal. You never see someone constantly updating the profile over and over again every 200ms.

On Fri, Feb 27, 2015 at 11:25 PM, Sacha Greif notifications@github.com wrote:

Yeah definitely. This is something I completely overlooked. Probably worth writing a blog post about it…

On Sat, Feb 28, 2015 at 2:37 AM, Ben Gott notifications@github.com wrote:

Thanks Sacha and Slava. Good teaching lesson for using field specifiers https://docs.meteor.com/#/full/fieldspecifiers, eh? And Telescope could probably use an overhaul too?

— Reply to this email directly or view it on GitHub < https://github.com/bengott/meteor-avatar/issues/47#issuecomment-76502839

.

— Reply to this email directly or view it on GitHub < https://github.com/bengott/meteor-avatar/issues/47#issuecomment-76515219>

.

— Reply to this email directly or view it on GitHub https://github.com/bengott/meteor-avatar/issues/47#issuecomment-76516561 .

bengott commented 9 years ago

Right.. Reactively reloading avatars every time something changes on the user object could get expensive. Other parts of the UI too, perhaps..