bengottlieb / Twitter-OAuth-iPhone

An easy way to get Twitter authenticating with OAuth on iPhone
http://www.standalone.com
799 stars 155 forks source link

iOS 5.0/ARC, fails on device in OAMutableURLRequest, CFRelease #85

Open robreuss opened 13 years ago

robreuss commented 13 years ago

Built the library, and my project which is working fine in the simulator but failing on the device in OAMutableURLRequest when attempting to call CFRelease.

I'm wondering if the fact that I'm using ARC for the rest of my project could be contributing to this? Of course, if that were the case, I wouldn't expect it to work in the simulator either. Nor does it make any sense that ARC would impact it, since ARC is applied at compile time, and the library is, of course, pre-compiled.

Perhaps the solution to my problem involves:

Changing the compilation settings for the library, to handle 5.0 or something else Improperly including the library in my project

Any hints or suggestions will be most appreciated!

bluewhaleinc commented 12 years ago

Did you hear back about this? Having the same issue but in the sim as well.

diegopizzocaro commented 12 years ago

same for me...thinking about switching to the iOS Twitter integrated library...although would gladly welcome any sugestion!!!

DarkMagicCK commented 12 years ago

I have this prob too... struggling with it for few days. Can any one give some suggestions?

DarkMagicCK commented 12 years ago

I tried author's DEMO but still failed. Nothing with ARC, all the iOS5 environment will get this problem. I tried to find something may help, in the callback OAuthTwitterController:authenticatedWithUsername , the username NSString is always null in iOS5 environment so I don't think it's something wrong with that OAMutableURLRequest. And the app can get the right PIN. Maybe something's wrong with the token or else, hope the author or someone else can solve this problem or this lib can't be used in iOS5.

NSDestroyer commented 12 years ago

Change http to https in SA_OauthTwitterEngine.m and this should fix the problem - like so:

self.requestTokenURL = [NSURL URLWithString: @"https://twitter.com/oauth/request_token"]; self.accessTokenURL = [NSURL URLWithString: @"https://twitter.com/oauth/access_token"]; self.authorizeURL = [NSURL URLWithString: @"https://twitter.com/oauth/authorize"];

DarkMagicCK commented 12 years ago

WOW!!!! Thanks NSDestroyer!! But I wonder how could this fix the problem. Twitter disabled the http link and only let https work?

SlaunchaMan commented 12 years ago

I changed the URLs but am still getting the error on iOS 4.3 when using ARC.