search

bengottlieb / Twitter-OAuth-iPhone

An easy way to get Twitter authenticating with OAuth on iPhone
http://www.standalone.com
799 stars 155 forks source link

Added support for adding the login dialogue in an existing navigation structure #88

Closed ijansch closed 7 years ago

ijansch commented 13 years ago

In my app I'm using a wizard style dialogue that allows users to login to various authentication sources. For this I'm opening the twitter login dialog controller via a pushViewController instead of a presentModelViewController.

The current Twitter-OAuth-iPhone implementation ads its own navigationBar; when using pushViewController on an existing navigationController, you end up with 2 bars.

In this pull request, I'm doing checks to see if a navigation bar should be added.

ijansch commented 13 years ago

I've updated the pull request. Not only the multiple navbars problem is fixed, but also the way the dialog is closed is now dependent on how it was opened (the original code assumes modal dialogues, so it always calls dismissModalViewController.

ijansch commented 7 years ago

Project is abandoned, closing pull.