search

bengourley / currency-symbol-map

A function to lookup the currency symbol for a given currency code
BSD 2-Clause "Simplified" License
326 stars 112 forks source link

✨ Added support for CAD dollar (Canadian Dollar) #78

Closed GalDayan closed 3 years ago

GalDayan commented 3 years ago

77

GalDayan commented 3 years ago

@namenyi

namenyi commented 3 years ago

@GalDayan thanks for the contribution! Let's discuss.

I've seen several different symbols for CAD, like $, C$, CA$, $CA, Can$, ...

When you look for information in the web, you can also find these different symbols, and most of them also say that $ is the official symbol:

the currency symbol is $ (link)

“$” is the currency symbol for both American and Canadian dollars (...) sometimes listed as Can$ or C$, to distinguish it from American dollars. (link)

It is abbreviated with the dollar sign $, or sometimes CA$, Can$ or C$ (link)

In general texts (...) the Translation Bureau recommends using the symbol Can$ to represent the Canadian dollar. The shorter variant C$. In a French document, the Translation Bureau recommends using the symbol $ CA. (link)

Based on these, I don't think we can clearly state that CA$ is the best choice here, as it's not the only, official symbol.

This information doesn't support a decision to introduce such a breaking change.

I'm closing this PR for now, but please let me know if you have clear evidence that CA$ can be considered as the official symbol.