search

bengreenier / browserd

Headless electron app platform for the cloud 🤕☁✨
https://hub.docker.com/r/bengreenier/browserd
MIT License
66 stars 7 forks source link

Enable audio 🔊 #18

Closed bengreenier closed 5 years ago

bengreenier commented 5 years ago

Adds support for audio capture at the rtc level.

bengreenier commented 5 years ago

Marking invalid - awaiting manual testing (by me)

bengreenier commented 5 years ago

ah this is fun. PRs get blocked now by the quality gate, as it wants better code coverage

bengreenier commented 5 years ago

allowing bypass of SonarCloud for now, while we track and work on #19

bengreenier commented 5 years ago

I'm seeing a bug with this when testing the desktop flag, adding invalid while investigating.

bengreenier commented 5 years ago

@phongcao - do you still have the ability to debug with the electron source?

I'm trying to understand if we're hitting this line which will mean we can never hide the cursor, yet.

Related to getUserMedia vs getDisplayMedia so discussing here.

Sorry - resolved on my own, by testing for this log. See #30

bengreenier commented 5 years ago

We'll close this and reopen a similar PR, given all the changes that would be needed to make this viable.