Better docker ☁📦 - Githubissues

bengreenier / browserd

Headless electron app platform for the cloud 🤕☁✨

https://hub.docker.com/r/bengreenier/browserd

MIT License

66 stars 7 forks source link

Better docker ☁📦 #26

Closed bengreenier closed 5 years ago

bengreenier commented 5 years ago

Improves our docker setup to rely on fewer custom-built dependencies (and instead to use other, existing projects/learnings).

Close #16
Fix #25

This also makes electron much happier at boot 😸

bengreenier commented 5 years ago

actually @phongcao @conrad465 let's hold off reviewing this - manual testing is yielding more strangeness than i anticipated.

bengreenier commented 5 years ago

Manual testing completed - this gets us feature parity with what we have, but with slimmer deps and a happier electron process.

Still would love (seriously) to spend time looking at #30 - but probably outside of the scope for now.

phongcao commented 5 years ago

@bengreenier Any idea why it looks being scaled when running in Docker? bug

bengreenier commented 5 years ago

@phongcao thanks, but there's no need for you to block due to conflicts, github/git will block that on it's own 😸 - if this meets your bar to ship, please approve.