[Feature request] Configure-able task timeout

bengreenier / vcpkg.nuget

vcpkg wrapped in nuget-y goodness 📦

MIT License

7 stars 3 forks source link

[Feature request] Configure-able task timeout #20

Closed nefarius closed 5 years ago

nefarius commented 6 years ago

Hey hey!

Fantastic package, it's the glue that was missing for an even more convenient integration into projects!

But... 😅 I immediately ran into the 10 minute timeout:

Warning MSB5002 The task executable has not completed within the specified limit of 600000 milliseconds, terminating.

I'm building POCO which requires ~12 to 17 minutes to initially build on my machine. The lazy way would ofc. be to just bump the timeout although I guess exposing it as an attribute would allow for more control.

Thanks for reading 🙂

nefarius commented 6 years ago

I implemented it myself and can submit a PR if you're interested. Cheers!

bengreenier commented 5 years ago

@nefarius wow super sorry I missed this (my github notifications are a bit of a mess) - I actually just stumbled across your usage of this digging through https://github.com/nefarius/Indicium-Supra (awesome project btw), small world. 😸

I'd love to merge that stuff in, if you have a minute to drop a PR my way. 🚀

nefarius commented 5 years ago

Hey hey @bengreenier 🙂

Thanks for the reply, I myself also suffer from not finding balance on GitHub notifications (you either drown in mails or miss important stuff, grrr).

Small world indeed 😆

Will craft a PR. Do bear in mind that I'm not an in-depth MSBuild guru so what I've thrown together "just works". I'm certain there are more elegant ways. Am open to feedback ofc.