search

bengrunfeld / expack

Express and Webpack boilerplate application
MIT License
284 stars 76 forks source link

chore: npm audit fix and linter error #14

Closed kheftel closed 4 years ago

kheftel commented 4 years ago

npm run buildDev was failing on a linter error, so I added ignore comments to logger.js

bengrunfeld commented 4 years ago

@kheftel-lkw Thanks for the work, but I actually want a linting error to be generated to show people that the linter works. They can fix it in 2 seconds. If it just compiles quietly, there's nothing to show that it's doing its job.

I've updated the packages and brought the project up to date in another PR.

kheftel commented 4 years ago

oh, I see. In that case, then, you should probably update your article to mention that two linter errors are raised, and two comments, not one, are required to quash them? It took me a bit to figure out. Maybe it'd be good to mention in "Installation & usage" in readme that it's expected that this code won't build as-is?

either way, thanks for the tutorial and code, it helped me figure out how to integrate express and webpack.

EDIT: I just noticed you added a comment to the code, my bad.