bengtmartensson / AGirs

A Girs infrared server for the Arduino

http://www.harctoolbox.org/Girs.html

GNU General Public License v2.0

55 stars 13 forks source link

Wrong #ifndef in file girs_pins_nano_shield.h #35

Closed gklement closed 6 years ago

gklement commented 6 years ago

Drop file from repos or change

ifndef GIRS_PINS_NANO_H

define GIRS_PINS_NANO_H

into

ifndef GIRS_PINS_NANO_SHIELD_H

define GIRS_PINS_NANO_SHIELD_H

but values will still depend on include order.

bengtmartensson commented 6 years ago

Thank you very much for the observation. Actually, these files (girs_pins_*.h) are not headers in the strict sense, so include guards in the traditional sense do not really make sense here, although I agree that it is currently quite confusing. I have instead opened the more general issue #36, that addresses this and other problems. Your feedback and other contributions are most welcome there.

bengtmartensson commented 6 years ago

This project is now using #pragma once instead of the legacy include guards.