search

bengtmartensson / AGirs

A Girs infrared server for the Arduino
http://www.harctoolbox.org/Girs.html
GNU General Public License v2.0
55 stars 13 forks source link

GirsLite-1.0.3-nano-flasher.sh doesn't work on Macs #59

Closed adrcunha closed 3 years ago

adrcunha commented 3 years ago

Because the OS check is hardcoded incorrectly:

# Mac defaults
if [ Linux == Darwin ]; then
  AVRDUDE=/Applications/Arduino.app/Contents/Java/hardware/tools/avr/bin/avrdude
  AVRDUDE_CONF=/Applications/Arduino.app/Contents/Java/hardware/tools/avr/etc/avrdude.conf
fi
adrcunha commented 3 years ago

Root cause: mkflasher.sh is missing an escape here:

https://github.com/bengtmartensson/AGirs/blob/eee6a2119cda997ad8310412828682357effaa7f/tools/mkflasher.sh#L68

which in turns hardcodes the OS the script is running on into the generated flasher script.

bengtmartensson commented 3 years ago

Was fixed by PR #60. Thank you!