Add transmit invert support

figgyc commented 2 years ago

This PR adds support for inverting the logic level of the IR send pin, for scenarios where HIGH = LED off and LOW = LED on. Fixes #61.

There are a few things I'm not happy with in this PR as-is, I'd appreciate some feedback:

https://github.com/figgyc/AGirs/blob/58f4f2083421dd2485615f80e21b2c6d5ac6eef9/examples/Girs/Girs.cpp#L162 : I feel like there's a cleaner way to convert an ifdef to a boolean than this but I'm not sure.
https://github.com/figgyc/AGirs/blob/58f4f2083421dd2485615f80e21b2c6d5ac6eef9/examples/Girs/Girs.cpp#L178 and L359: I've used the PWM_PIN define from the Infrared4Arduino library to fill in the default argument. That doesn't seem very clean to me, but as far as I can tell the library doesn't actually expose the PWM pin anywhere so I couldn't think of any other way, except for changing the order of the arguments which felt equally weird to me.

bengtmartensson commented 2 years ago

Hi George, thanks for the PR, and please excuse the delay; health-dependent.

I put this "on hold" waiting for bengtmartensson/Infrared4Arduino#79

bengtmartensson commented 2 years ago

Closing since the dependent PM bengtmartensson/Infrared4Arduino#79 has been closed.

bengtmartensson / AGirs