search

bengtmartensson / AGirs

A Girs infrared server for the Arduino
http://www.harctoolbox.org/Girs.html
GNU General Public License v2.0
55 stars 13 forks source link

Minimal RX/TX on current ESP32 Arduino core, including wifi server #72

Open izzy84075 opened 1 week ago

izzy84075 commented 1 week ago

Depends on https://github.com/bengtmartensson/Infrared4Arduino/pull/90 to bring the ESP32 support up to date.

Touches quite a bit, but I tried to make the changes minimally invasive where possible.

Adds basic ESP32 support in AGirs, using an M5Capsule and an IR Receiver/Transmitter Grove module from M5Stack as my "reference" platform.

Receive, Transmit, and Decode work (when enabled) over USB serial on my M5Capsule.

Also adds a WiFi equivalent of the Ethernet TCP server, including connecting to wifi. I have not tested how it handles losing connection, however.

Receive and Transmit work over TCP on my M5Capsule, enabling Decode seems to lead to crashes that I am not familiar enough with the ESP32 to debug yet.

bengtmartensson commented 1 week ago

@izzy84075, thank you very much for your PR. You must have put a lot of work into it; much appreciated. Also, making the PR as a series of smaller (but all consistent) commits, makes it easier to merge, but do not worry this time.

izzy84075 commented 1 week ago

Yes, I figured this would need work before being merged. I'm using this as my IR gadget currently, so I'll keep working on it as I go.

Would splitting this into several PRs be preferable?

I'll reply to the other comments soon.

bengtmartensson commented 1 week ago

Would splitting this into several PRs be preferable?

In general, yes. As an alternative, you can have several commits in a PR. Every commit and PR should be a logically consistent state; change ideally one "thing" only.