search

bengtmartensson / IrScrutinizer

IrScrutinizer is a program for IR signal analysis, decoding, generation and much more.
http://www.harctoolbox.org
GNU General Public License v3.0
321 stars 42 forks source link

Fix export format Homeass-Broadlink IR #477

Closed bengtmartensson closed 1 year ago

bengtmartensson commented 1 year ago

Said export format is broken and to be fixed.

In the future extend for 433 MHz RF.

GMichu commented 1 year ago

How is this export format broken? I found this wonderful project while looking for a way to convert various formats into homeass-broadlink. So far, I have not encountered problems, so I ask to know what to look out for.

bengtmartensson commented 1 year ago

First, the lenght parameter in the data is wrong: just counts the number of unencoded durations instead of the number of bytes after the 1--2 byte coding. Secondly, the command names were wrong, I think they were all called power_on or power_off or so.

I just checked in a partial fix; fixes the second problem but not the first one. (You can just drop the file https://raw.githubusercontent.com/bengtmartensson/IrScrutinizer/master/src/main/config/exportformats.d/Homeass_broadlink.xml into your exportformats.d directory, and you will be set.) It is possible that the reading programs or hardware does not check the lenght. Please give feedback.