benhanover
commented
3 years ago @listguy thanks for the constructive criticism ! ill keep it in mind for future projects. I've been working with @dGorgula, and @amit751
Open listguy opened 3 years ago
benhanover
commented
3 years ago @listguy thanks for the constructive criticism ! ill keep it in mind for future projects. I've been working with @dGorgula, and @amit751
👍👍👍
Great error handling Catching and logging errors to client is done correctly, but not all cases are covered.
Spinner From what I saw spinner is handled correctly, but will spin forever if a request fails.
👎👎👎
Client server communication Changes in client should only occur after the server send an OK response.
functions declaration You declared some helper functions inside other helper functions. Which means every time your father helper function runs it will need to declare them over and over again. A waste pf resources and time. Next time declare your helpers at the highest level possible
@benhanover Please tag your partner