Adding support for dict_to_protobuf

benhodgson / protobuf-to-dict

A small Python library for creating dicts from protocol buffers. Useful as an intermediate step before serialization (e.g. to JSON).

Other

226 stars 108 forks source link

Adding support for dict_to_protobuf #4

Closed ninowalker closed 10 years ago

ninowalker commented 11 years ago

Adds the reversing function.
Adds unit tests for both.

Thanks from Livefyre.

ninowalker commented 11 years ago

@benhodgson ~ ping.

benhodgson commented 11 years ago

@ninowalker Thanks for your extensive contribution! I’ll take a look at this as soon as I get a bit of free time.

ninowalker commented 11 years ago

nudge

lawik commented 10 years ago

I'd really like to see this added. Glad I didn't have to write this library by the way :)

Would love to be able to get the reverse-function as well using pip and not patching.

ninowalker commented 10 years ago

@lawik in the interim you can point pip/etc to the Livefyre repo; it's stable, used in production, and has no other material changes. I think this should do it:

pip install https://github.com/Livefyre/protobuf-to-dict/archive/master.zip#egg=protobuf-to-dict

lawik commented 10 years ago

Ah, nice, have never tried that.

ninowalker commented 10 years ago

@benhodgson Semi-annual nudge. @lawik is also interested.

bdejong commented 10 years ago

There is a new hope: https://twitter.com/blahpro/status/492005653289115648 ;-)

benhodgson commented 10 years ago

Merged! I'm sorry that this took ~16 months.

benhodgson commented 10 years ago

@ninowalker @jaklaassen Thank you for your contributions.

benhodgson commented 10 years ago

Okay, released on PyPI.

bdejong commented 10 years ago

YEAH! Thanks Ben! :+1: