benhoepner / National-Park

SIL Open Font License 1.1
12 stars 4 forks source link

Spacing + Kerning #22

Open vv-monsalve opened 1 year ago

vv-monsalve commented 1 year ago

The spacing at ExtraLight looks tight, especially compared to ExtraBold. The kerning groups need to be added. Please:

Screen Shot 2023-08-01 at 22 12 20 Screen Shot 2023-08-01 at 22 18 53
aherstowski commented 1 year ago

@vv-monsalve seeking I will work on the overall spacing first. Seeking some advice from you about the kerning. Do you think I should remove all current kerning? Start over with the kerning groups. Thanks for any advice,

vv-monsalve commented 1 year ago

Do you think I should remove all current kerning? Start over with the kerning groups.

This would be the best option, especially for the ExtraLight master, where spacing needs revision. Following the order of reviewing spacing before kerning is also key to avoiding unnecessary extra kerning pairs that good spacing often prevents.

aherstowski commented 1 year ago

@vv-monsalve sorry for the absence! Start of school was nuts and now I have Covid but I am on the mend! here is my list and order... been thinking about it :) just no action.

Start with… Review the overall weight of the master …

Create a temporary instance at a lighter value (and then re-adding it as a master. Please make it after performing different tests...)

(Q) Get Feedback: what would be the best way for me to get feedback at this point to choose the new master for extra bold

*ensure the counters, joins, and other shapes don't get closed, affecting the legibility

Once weights are correct move onto...

Review the diacritics' weight, height, and distance from the base letters of diacritic marks. Particularly the Stacked diacritics used in Vietnamese

Last spacing and kerning

Review the overall spacing of the font (remove existing kerning and start fresh)

Create the Kerning groups (starting with kerning groups)

Only after doing the above, check the kerning for the entire font

vv-monsalve commented 1 year ago

Hi @aherstowski Sorry to hear you have Covid! I hope you recover well and soon :)

(Q) Get Feedback: what would be the best way for me to get feedback at this point to choose the new master for extra bold

The best thing for this would be to checkout to a new branch (e.g. extrabold-weight) make the tests, and push the source file + proof images there so that we can review it. Also, some images could be added to the ExtrBold issue :) Then we can have a meeting if needed.

Review the overall spacing of the font (remove existing kerning and start fresh)

Let's start with the lighter master and we can review it from there :)

aherstowski commented 1 year ago

Got it! I am alive. My mind is back and ready to go.

Started with the Light Master getting the spacing corrected. I see the proof in the folders as a pdf but not as a file. Is that somewhere for me to download? or I can make my own? I am using FontProofer (do you know it? Peter Nowell is great and the tool is awesome!) https://fontproofer.com/

vv-monsalve commented 1 year ago

Hi @aherstowski,

I see the proof in the folders as a pdf but not as a file.

I've made a PR to your master with the .indd file used for it.

or I can make my own? I am using FontProofer (do you know it?

Of course you can create your proof docs. Please remember to include them in the added proofs folder under documentation dir. I've heard of fontproofer but haven't used it yet (since we use mainly our tools like diffenator2). You sound really happy with it. Please share the proofs so I can have a look at them :)

aherstowski commented 10 months ago

Hi @aherstowski Sorry to hear you have Covid! I hope you recover well and soon :)

(Q) Get Feedback: what would be the best way for me to get feedback at this point to choose the new master for extra bold

The best thing for this would be to checkout to a new branch (e.g. extrabold-weight) make the tests, and push the source file + proof images there so that we can review it. Also, some images could be added to the ExtrBold issue :) Then we can have a meeting if needed.

Review the overall spacing of the font (remove existing kerning and start fresh)

Let's start with the lighter master and we can review it from there :)

aherstowski commented 10 months ago

@vv-monsalve Happy New YEAR!

Extra Bold... I am not sure how to do this.... "The best thing for this would be to checkout to a new branch (e.g. extrabold-weight) make the tests, and push the source file + proof images there so that we can review it. Also, some images could be added to the ExtrBold issue :) Then we can have a meeting if needed."

Diacritics Review the diacritics' weight, height, and distance from the base letters of diacritic marks. Particularly the Stacked diacritics used in Vietnamese (done but need your review again, I revised and redid all the anchors of if there are issues they can be more easily fixed!)

Kerning Review the overall spacing of the font (remove existing kerning and start fresh) (Opened up Light Master please review to see if it is enough, in first pages of the proof it shows it as it and with + tracking)

Create the Kerning groups (starting with kerning groups) (I have set all Kerning groups)

Only after doing the above, check the kerning for the entire font (for sure will do this at the very end)

I put new proofs in the documentation folder but if this is easier here they are...

Font Proof 1 ExtraLight (Master).pdf Font Proof 2 Regular (Master).pdf Font Proof 3 ExtraBold (Master).pdf

aherstowski commented 10 months ago

@vv-monsalve Googling Branches now :)