Diacritical marks

[twardoch]

ogonek

The Polish diacritics in the current National Park sources are very good! I wouldn’t change a thing. Not just the letters with ogonek letters but also the łŁ (lslash/Lslash)!

caron, circumflex

The apostrophic caron (in ď ľ ť) is good.

The circumflex and caroncomb marks in ExtraLight are a bit too thick. They go to 53-54 units at the junction, while the diagonals in Z are 47 and in z are 44. That junction in circumflex/caron makes an unpleasant black blob. 

In acute and grave, the thick end is sort of OK because it's reminiscent of a teardrop (but it wouldn’t hurt if it were a tad lighter), but in ExtraLight, circumflex and caron are visually too striking — especially caron, where the junction is at the bottom. In Regular and ExtraBold, it’s all good. 

dblgrave

The body of dblgrave should be shifted a bit to the right in the ExtraLight master (or its _top anchor to the right). Now it appears geometrically centered over letters, i.e. optically too much to the right. In Regular and ExtraBold it’s OK.

ldot

Please reduce the width of ldot (keep the dot where it is) so that in the sequence /ldot/l, the dot appears perfectly centered (horizontally between the two ls) in all weights.

That’s all for now :)

[vv-monsalve]

@aherstowski you could check the Diacritics section in the GF-Guide when checking them

[vv-monsalve]

Inspecting the marks in the source file at commit 8a9e37a, please check the following:

• [x] Marks weight consistency (weight, style, size, position)
  • [x] Some of them look lighter than others e.g. circumflex, hookabove. tilde has changed only in some glyphs, etc.
  • [x] There are some alignment regressions e.g. Y (although the fix for this letter is already covered in the latest source file included in the open PR)
  • [x] Commaaccentcombbase.case is too close to the base glyph and missaligned in T
• [x] Review the anchors in marks and base glyphs are present and ensure the type (loclVIT), name and position are as expected to be able to produce the composite glyphs automatically
• [x] All the composite glyphs are generated with the intended marks. You can create or update them by running the command Create composite (with the option key, Glyphs will create them in all masters). Many of the glyphs are showing inconsistencies when updating them.