search

benhoff / CHATIMUSMAXIMUS

Master chat GUI for Youtube, Twitch, Livecoding, and WatchPeopleCode
GNU General Public License v3.0
41 stars 14 forks source link

Redo handling of settings state #17

Closed benhoff closed 8 years ago

benhoff commented 8 years ago

very hackish in a lot of places.

benhoff commented 8 years ago

I am not a huge fan of this line, which changes the setting state unexpectedly. https://github.com/benhoff/CHATIMUSMAXIMUS/blob/master/chatimusmaximus/__init__.py#L29

It would probably be better to have a "verify settings state" method or similar.

After looking at the settings handling in MainWindow, it's better than I had anticipated. So likely just adding up the aforementioned method would be good enough.

benhoff commented 8 years ago

This has been fixed at least by this commit. fffda0c8c95eb7bbe31b48bc4c5c05ed61877fe9