search

benhoneywill / hikerherd

hikerherd helps you plan your adventures and organize your gear while reducing the weight your pack
Apache License 2.0
34 stars 5 forks source link

Scroll overflow issues on the pack screen in safari and on mobile #58

Open benhoneywill opened 2 years ago

benhoneywill commented 2 years ago

In safari the category columns overflow the viewport and can't be scrolled.

On mobile the same issue can sometimes occur. It seems to be due to the use of view height units

Alex-AK commented 2 years ago

I found this article on mobile view height calculation helpful for addressing the issue on other projects I've worked on. This is likely from the fixed-layout.tsx use of height="100vh".

benhoneywill commented 2 years ago

Hi @Alex-AK thanks for the link!

I will read that article properly when I get the chance. Looks like they are using window.innerHeight which means this solution may not work with server side rendering, but when I am free to pick up this issue I will keep this technique in mind. It might work fine with a default value!

Thanks again!