search

benhovinga / caf-ranks

Complete list of the Canadian Armed Forces rank structure in JSON format (bilingual)
https://www.npmjs.com/package/caf-ranks
Other
0 stars 0 forks source link

Rank Property Names #11

Closed benhovinga closed 2 days ago

benhovinga commented 3 days ago

The element property on Rank type is an array and should be pluralized to elements.

benhovinga commented 2 days ago

element is not the best name for this property and CAFElement just looks terrible.

Possible choices:

With these names should the values also be changed to "army", "navy", "air" or "airforce"?

I will change it all to Command for now but keep the current values the same.