benhoyt / inih

Simple .INI file parser in C, good for embedded systems
Other
2.46k stars 492 forks source link

add autotools build and GitHub release workflow #141

Closed bluesquall closed 2 years ago

bluesquall commented 2 years ago

Here's a set of changes that will support the autotools build of a shared & static libraries, and a GitHub release workflow to put the distcheck'ed tarball on the release page.

I need these things for a build on a legacy system, and figured they may be useful to others. I could also draft a CMake build, if you're interested.

benhoyt commented 2 years ago

Hi @bluesquall, thanks for your contribution. Unfortunately I've decided I'd rather not keep up with and maintain N build systems, and we've already got support for the fairly well-used Meson build system, so I'm not planning to add others to the main inih repo. Feel free to add it in your own fork or repo, though!

See previous similar discussions at https://github.com/benhoyt/inih/pull/105, https://github.com/benhoyt/inih/issues/71, and https://github.com/benhoyt/inih/issues/133.

eli-schwartz commented 2 years ago

I need these things for a build on a legacy system

I assume this means some system which for some reason, python is not ported to it?

Although Meson itself is written in and requires python, there's a c99 port at https://sr.ht/~lattis/muon which can build inih. The muon port is tested on Linux and netbsd, but I don't know what system you're using. It should hopefully work okay on any POSIX-ish system, and at the very least it will be far easier to patch for missing support than it would be to patch both Meson and the entirety of python.

bluesquall commented 2 years ago

It is a system that does not have python (at least not usable). I am looking forward to the time when I don’t need to support it anymore, but for now I take what I have and do what I can.

On Wed, Jul 20, 2022, at 20:40, Eli Schwartz wrote:

I need these things for a build on a legacy system

I assume this means some system which for some reason, python is not ported to it?

Although Meson itself is written in and requires python, there's a c99 port at https://sr.ht/~lattis/muon which can build inih. The muon port is tested on Linux and netbsd, but I don't know what system you're using. It should hopefully work okay on any POSIX-ish system, and at the very least it will be far easier to patch for missing support than it would be to patch both Meson and the entirety of python.

— Reply to this email directly, view it on GitHub https://github.com/benhoyt/inih/pull/141#issuecomment-1191002816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5PZUDKSXHEQ6NDSMUAITVVDBENANCNFSM54BZMXEA. You are receiving this because you were mentioned.Message ID: @.***>

bluesquall commented 2 years ago

Fair enough.

I’ll keep an active fork for this platform, and try out meson/muon when I’m on more modern systems.

On Wed, Jul 20, 2022, at 18:28, Ben Hoyt wrote:

Hi @bluesquall https://github.com/bluesquall, thanks for your contribution. Unfortunately I've decided I'd rather not keep up with and maintain N build systems, and we've already got support for the fairly well-used Meson build system, so I'm not planning to add others to the main inih repo. Feel free to add it in your own fork or repo, though!

See previous similar discussions at #105 https://github.com/benhoyt/inih/pull/105, #71 https://github.com/benhoyt/inih/issues/71, and #133 https://github.com/benhoyt/inih/issues/133.

— Reply to this email directly, view it on GitHub https://github.com/benhoyt/inih/pull/141#issuecomment-1190934334, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5PZSNYL6SQ3ISTD64QL3VVCRVBANCNFSM54BZMXEA. You are receiving this because you were mentioned.Message ID: @.***>

bluesquall commented 2 years ago

If you would be interested in the GitHub actions release workflow using meson instead of autotools, I'd be happy to draft that in a different PR. I totally understand if that is more to maintain, too.