search

benhuson / Taxonomy-Images

Enables WordPress users to easily associate images from the media library to categories, tags and custom taxonomies.
https://wordpress.org/plugins/taxonomy-images/
21 stars 5 forks source link

consider deprecate filters with dash #33

Open LC43 opened 7 years ago

LC43 commented 7 years ago

Hi, great plugin!

Would you consider deprecating your filters with dash and replace them with underscores? WP coding standards advice to use underscores in filters/actions.

I would suggest just deprecating for now, and only in future, to remove it.

thanks

benhuson commented 7 years ago

Yes, that sounds like a good idea.

As part of that I would probably review how filters are used through the plugin and the arguments that can be passed to them.

Not something I have tim to jump in and do at the moment, but will certain consider doing this in due course.

Thanks