search

benhuson / wp-subtitle

Development of the WordPress WP Subtitle plugin. http://wordpress.org/plugins/wp-subtitle/
33 stars 16 forks source link

Translation does not work (wrong domain identifier) #8

Closed davidspiess closed 9 years ago

davidspiess commented 9 years ago

The TEXTDOMAIN constant in wp-subtitle.php has to point to wp-subtitle instead of wps_subtitle. You should also consider passing the domain string directly to the __ method instead of using a constant.

See https://markjaquith.wordpress.com/2011/10/06/translating-wordpress-plugins-and-themes-dont-get-clever/ http://ottopress.com/2012/internationalization-youre-probably-doing-it-wrong/

benhuson commented 9 years ago

Thanks for pointing that out - I hadn't twigged that that would cause an issue for other parsers.

davidspiess commented 9 years ago

It isn't a big issue :)

benhuson commented 9 years ago

Fixed in https://github.com/benhuson/wp-subtitle/commit/805a5bd3c6fdf0cee0876fc172519a5cd94b92dc

hatsumatsu commented 9 years ago

Is this fix available via the Plugin Directory / one click update? That would be great! :)

benhuson commented 9 years ago

Now added to the plugin directory as version 1.5 so should be available shortly.