search

benhutchins / docker-mediawiki

Docker container for MediaWiki
https://hub.docker.com/r/benhutchins/mediawiki/
Other
29 stars 153 forks source link

Upgrade to 1.27.3 and resolve build/run issues #16

Closed rbong closed 7 years ago

rbong commented 7 years ago

This line is sitting on master right now:

# Waiting in antiticipation for built-time arguments
# https://github.com/docker/docker/issues/14634
ENV MEDIAWIKI_VERSION wmf/1.27.0-wmf.9

This issue is closed, and so I have bumped up the version to 1.27.3. 1.23 is reaching end of life this month and 1.27 is LTS. I have also changed the mediawiki downloading method to that seen on other branches, since this is a minor release and not a bleeding edge version.

On rebuilding, you will encounter an issue with debian:sid. Sid is always the unstable branch. I have switched it to debian:jessie, which appears to be what this was actually working with previously. I also tested it with the php image and dependencies seen on other branches and it works fine, but I'm leaving it because I'm not sure why debian is used (because master is bleeding edge maybe?).

I also fixed an issue where it does not work after running once. ln -s /usr/src/mediawiki/* . will fail because the links already exist, causing the image to fail to start up because of set -e. I have merely changed it to ln -sf so it will overwrite existing links.

I have also fixed an issue where no links from $MEDIAWIKI_SHARED are set because the files in /var/www/html already exist from the previously mentioned link statement.

If you'd like me to break up this into different pull requests, please let me know. If this isn't appropriate for master, consider putting this or similar changes on a 1.27 branch and releasing it.

rbong commented 7 years ago

I'm closing this - not sure what remote this is based off of after seeing the change summary.