Fix map attribute name

benhutchins / dyngoose

Elegant DynamoDB object modeling for Typescript.

https://www.npmjs.com/package/dyngoose

ISC License

89 stars 14 forks source link

Fix map attribute name #600

Closed cbumstead closed 1 year ago

cbumstead commented 2 years ago

Breaking Change

Why did you make these changes?

To support using attribute name when using a map attribute

What's changed in these changes?

Modified map.ts, added a unit test

What do you especially want to get reviewed?

map.ts changes

Submission Type

[x] Bugfix

All Submissions

[x] Have you added an explanation of what your changes?
[x] Have you written new tests for your changes, as applicable?
[ ] Have you checked potential side effects that could make bad impacts to other services?

benhutchins commented 2 years ago

I appreciate the pull request @cbumstead!

I'll need to revise your edits to package.json before merging, but we can definitely get this merged in.

cbumstead commented 1 year ago

thanks, @benhutchins I revised the package.json

benhutchins commented 1 year ago

@cbumstead Thank you so much for keeping this PR alive with your recent update. I was reviewing it to get it merged in noticed the implementation was changing the way the map attribute's attributes object mapped from attribute names to property names. I pulled your change in and revised it to keep it consistent with the way the table attributes work, but this issue has been fixed in the new release 4.1.0.

Also, love the vscode launch config addition. Makes sense to help others who use vscode and the integrated debugger functionality.

Thank you for the contribution!