search

benhutchison / prickle

Prickle is a library for easily pickling (serializing) object graphs between Scala and Scala.js.
64 stars 12 forks source link

play-json #2

Open antonkulaga opened 10 years ago

antonkulaga commented 10 years ago

It would be nice to see play-json pickler (maybe as separate subproject) like it is in scala-js-picklers

benhutchison commented 10 years ago

That shouldn't be very difficult. I'll try to add this at some point.

On Sun, Sep 28, 2014 at 7:29 AM, Anton Kulaga notifications@github.com wrote:

It would be nice to see play-json pickler (maybe as separate subproject) like it is in scala-js-picklers

— Reply to this email directly or view it on GitHub https://github.com/benhutchison/prickle/issues/2.

antonkulaga commented 9 years ago

I started coding play-json support but had to pause due to more importants todos. But what I undestood from my attempt is that generic test suites are missing, so everyone can make a subproject for his/her own favourite json lib and extend some generic test suite to test if everything is ok with readers/writers.

benhutchison commented 9 years ago

IIRC supporting another json framework should involve just a new PBuilder and PReader:

https://github.com/benhutchison/prickle/blob/master/shared/src/main/scala/prickle/PConfig.scala#L38

Currently the tests dont really focus on this in isolation, partly because its lower risk relative to the main un/pickling logic. Some explicit contract testing along these interfaces would be valuable and not especially difficult, and could be made generic.

On Mon, Feb 16, 2015 at 11:33 AM, Anton Kulaga notifications@github.com wrote:

I started coding play-json support but had to pause due to more importants todos. But what I undestood from my attempt is that generic test suites are missing, so everyone can make a subproject for his/her own favourite json lib and extend some generic test suite to test if everything is ok with readers/writers.

— Reply to this email directly or view it on GitHub https://github.com/benhutchison/prickle/issues/2#issuecomment-74446278.