CRAN release? - Githubissues

beniaminogreen / zoomerjoin

Superlatively-fast fuzzy-joins in R

https://beniamino.org/zoomerjoin/

GNU General Public License v3.0

97 stars 5 forks source link

CRAN release? #92

Closed JosiahParry closed 7 months ago

JosiahParry commented 9 months ago

Is your feature request related to a problem? Please describe.

This package is a great example of using R and Rust together and serves to fill a performance gap in the R ecosystem. The R community would benefit greatly from the publication of the library on CRAN.

Have you considered publishing to CRAN?

beniaminogreen commented 9 months ago

Hi Josiah,

Thanks for reaching out. I have considered publishing the package to CRAN, but from what I have read on the CRAN website and in this blog post, the process seems very difficult for packages that use both R and Rust.

There are a few things I need to get to before this, but I will consider trying to get this on CRAN in the next few months. Do you have any experience publishing Rust crates to CRAN or any resources you could share on the process?

JosiahParry commented 9 months ago

I am more than happy to help! I have an existing PR to rextendr that would make this process a bit simpler. I have published two R packages to CRAN that utilize extendr and would be happy to help you in the submission process! :)

beniaminogreen commented 9 months ago

I am super busy over the next two weeks, but I will definitely take you up on that offer! I have to make a few changes to the package before I am ready to submit to CRAN, but will definitely ask for some advice / help + use the fork you mention when the time comes for it. The fork looks especially useful - thanks so much for writing it and sharing.

Specifically on my list are:

[X] refactor the rust code to use the extendr datatypes Strings and Doubles, which I did not know about when I originally wrote the package
[ ] Make sure the package passes R CMD check as there are still some undocumented function arguments
[ ] Compile a list of authors for the dependency rust crates to comply with the CRAN authorship policy

Best, and many thanks for your help, Ben

beniaminogreen commented 7 months ago

Back from my holidays and ready to make an effort on this front. I've found your branch of rextendr invaluable in preparing the package for CRAN submission - thanks so much for making it! I don't think it would have been possible for me to prepare the package without the helper functions you wrote.

A quick question for you - this is basically the last NOTE I have to handle before a CRAN submission. Have you ever seen this before / have any leads for what to do to resolve it? I'm pretty mystified by it and did a search and can't find any of those flags in the package sources using grep.

Best, Ben

beniaminogreen commented 7 months ago

I think I've managed to resolve this - looks like this was something that was specific to my Arch Linux machine. The only remaining NOTE I have before I am done with the submissions process is this one on the cran win-builder. Is this something to be expected when using rextendr, or should I do some digging to try and resolve this?

Best, Ben

beniaminogreen commented 7 months ago

Fixed this and submitted to CRAN. Turned out to just be an issue with using an older version of the extendr-api crate.

JosiahParry commented 7 months ago

Well! Good for you! I was just about to comment saying I'll give this a clone and once over this evening. 🤞🏼

beniaminogreen commented 7 months ago

Excited to be able to share that the package has been accepted to CRAN and should be installable shortly. Thanks for your help @JosiahParry, and closing the issue now!