benibela / xidel

Command line tool to download and extract data from HTML/XML pages or JSON-APIs, using CSS, XPath 3.0, XQuery 3.0, JSONiq or pattern matching. It can also create new or transformed XML/HTML/JSON documents.
http://www.videlibri.de/xidel.html
GNU General Public License v3.0
681 stars 42 forks source link

Socks - proxy support ? #82

Closed Baltazar500 closed 2 years ago

Baltazar500 commented 2 years ago

Can you add socks - proxy support ?

benibela commented 2 years ago

Yes

Not sure if I should include it in the --proxy option (e.g. --proxy socks=123.1.1.1 or make a new option like --socks-proxy (e.g. --socks-proxy 123.1.1.1)

Baltazar500 commented 2 years ago

@benibela, I think it's better to make a new option. As in curl.

benibela commented 2 years ago

I am not trying to copy curl. And curl has far too many different proxy options

Each --option makes the startup slower,

benibela commented 2 years ago

Implemented in https://github.com/benibela/internettools/commit/c7a53031081210c2985ebf589e2d69f9c94d4f4c

Baltazar500 commented 2 years ago

OK. It works. But you need to indicate in the output "--help" about "--proxy socks=IP:PORT" :)