search

benignware / wp-bootstrap-hooks

A collection of filters and actions for Bootstrap-based themes
MIT License
7 stars 3 forks source link

tag class now badge and menu markup suggestions #1

Open misiman opened 7 years ago

misiman commented 7 years ago

Hi and thanks for sharing.

I found a couple of minor issues which you might not know about:

1) Bootstrap have resolved the Wordpress .tag class conflict which has now been replaced by .badge - see https://github.com/twbs/bootstrap/pull/21020 2) In bootstrap-menu.php, it appears that add_filter( 'wp_nav_menu_args', 'wp_bootstrap_nav_menu_args', 10, 2 ); is removing the .nav-link class from the markup. 3) In bootstrap-menu.php, some of the class outputs have leading or trailing spaces which need trimming before being added to the attributes array. 4) Bootstrap-menu.php is missing the

rexblack commented 7 years ago

Hey man, great! I really appreciate your findings. It's also very likely that i'll fix them soon as i use this plugin in recent projects. For the meantime, you could stick to alpha.5

Currently every new alpha brings new changes (and that's of course desirable for a series of alpha), although lots of people are already using bs4. It's kind of hard to keep dependent work up to date. Hopefully the final release arrives soon...