search

benini / scid

Other
44 stars 14 forks source link

tag for version 5.0 #102

Closed rolandlo closed 1 year ago

rolandlo commented 1 year ago

Has Scid 5.0 been released? It looks so from https://sourceforge.net/projects/scid/files/Scid/Scid%205.0/ and https://github.com/benini/scid/commits/github However there is no v5.0.0 tag (see https://github.com/benini/scid/tags), which is confusing. For updating the flatpak a tag would be needed.

benini commented 1 year ago

Thanks, I have released the 5.0.0 version an updated the flatpak manifest. Please let me know if everything is ok.

rolandlo commented 1 year ago

It looks fine. If you create a PR for the updated flatpak manifest (with removed icon, desktop and metadata file) on the flathub/io.github.benini.scid repository, we can check out the automatic build.

benini commented 1 year ago

I'm thinking about adding the scid_extra.zip package (https://sourceforge.net/projects/scid/files/Scid/Scid%20Latest/) using extra-data. It should be enough to download the package and decompress it in the /app/scid/scid folder. What's you opinion?

rolandlo commented 1 year ago

The content of scid_extra.zip looks fine. However I don't think you need to use extra-data. The extra-data option (as I understand) was designed to include proprietary software without redistributing it. Just use a source of type "archive" and move it to the right place using the install command with the -t option like

- name: scid-extra
  buildsystem: simple
  build-commands: 
    - install -D ./* -t /app/scid/scid
  sources:
  - type: archive
    url: https://sourceforge.net/projects/scid/files/Scid/Scid%20Latest/scid_extra.zip
  - sha256: 0175c80da101278b20628ca70670a93b2d90129e

I haven't tested it, but at least that's the way I would try it.

benini commented 1 year ago

I would like the extras to be optional. Not only they take space (300MB), but some user would subsequently manually update the players' data.

rolandlo commented 1 year ago

I would like the extras to be optional. Not only they take space (300MB), but some user would subsequently manually update the players' data.

I don't think optional data is possible for a flatpak via extra-data, since there is no option to install extra-data or not when installing a flatpak. The point of extra-data is that it gets downloaded during install (not that it is optional).

It seems a custom extension like described here needs to be defined (and then one can either install via flatpak install --no-related <app-id>, or without the --no-related option).

benini commented 1 year ago

Thanks. Maybe in the future.