search

benini / scid

Other
44 stars 14 forks source link

#209 FICS premove #142

Closed ukscid closed 1 year ago

ukscid commented 1 year ago

Premove (as a illegal move) in current position was ignored by addMove. Looking for fics::premove in addMoveUCI is "to late"

benini commented 1 year ago

This doesn't seems ok: the direct invocation of addMoveUCI will now bypass FICS's checks. Nonetheless, these checks should be within the FICS module rather than within this functions.

ukscid commented 1 year ago

I can't see where addMoveUCI is called direct for doing a premove. But adding the fics's check in addMoveUCI again is also not the full fix. I see that a premove with a promotion throws an error. I'll investigate.