search

benini / scid

Other
44 stars 15 forks source link

This fixes a bug for recent files with wrong file extensions #173

Closed ukscid closed 9 months ago

ukscid commented 9 months ago

Bookmarks from database si5 causes double entries in recent file list like"filename" and "filename.si5". If this bookmarks are opened then this causes entries with wrong filenames like "filename.si4"

This fix has the disadvantages that the extension si5 is not hidden. Maybe you find a better solution. I do not know when and how the si5 extension can or should be dispensed.

ukscid commented 9 months ago

Thanks. I optimized your suggestion. ::notify::DatabaseChanged is added to update the database name in the window title.

ukscid commented 9 months ago

Filename without extension: This filename without extension (for .si5 files) is set by https://github.com/benini/scid/blob/ec4db186c16e93b6b50c9dd35fc9480f8d5cd4ce/tcl/file.tcl#L185 then later on https://github.com/benini/scid/blob/ec4db186c16e93b6b50c9dd35fc9480f8d5cd4ce/tcl/file/bookmark.tcl#L159 stores the database filename without the extension in the bookmark. When the bookmark is used there is the filename without extension.

benini commented 9 months ago

It's a mess. I'll think about it